Initial support for keys following zipfian #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows memtier generate keys that follows zipfian
distribution. An additional parameter --key-zipf-exp is introduced,
meaning P(Key = n) ~ n^{-exp}, which is bounded to (0, 5) to be sane.
The range of keys are limited to positive in this version.
Signed-off-by: Su Lifan <[email protected]>
Signed-off-by: Su Lifan <[email protected]>
Closed
filipecosta90
requested review from
filipecosta90
and removed request for
yossigo and
YaacovHazan
- tracks and counts command execution using redis-py Monitor class
- Refactor Zipfian tests to avoid repetition
filipecosta90
requested changes
May 27, 2025
There was a problem hiding this comment.
small request for change @paulorsousa . Given your tests clearly explain the --key-zipf-exp implications I believe we should also make sure the user gets it when doing the --help, meaning please add your extra detail on --key-zipf-exp description.
PS: really cool testing strategy!!! Kudos!!!
filipecosta90
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows memtier generate keys that follows zipfian
distribution. An additional parameter --key-zipf-exp is introduced,
meaning P(Key = n) ~ n^{-exp}, which is bounded to (0, 5) to be sane.
The range of keys are limited to positive in this version.
Signed-off-by: Su Lifan [email protected]